-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure TypedArrays are supported everywhere #3215
Comments
I just opened #3339, and by my count this is the 6th bug so far that would have been caught if all of the mocks were run with typed arrays. Full list:
So it seems to me that time/resources spent on preventing this class of issues in testing would be pretty worthwhile. |
And #3595 |
... after transform _module.calc loop - that way filter transforms that remove all data coordinates don't result in errors - of all the mocks listed in mock_lists.js, only 'scattercarpet' and 'world-cals' still error out (wip)
Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson |
Discussion from #3210:
And how do we catch these problems in new features then? I guess if there's a simple command to run all of our mocks with TypedArrays, we could make this part of the pre-publish checklist?
The text was updated successfully, but these errors were encountered: