unsubscribe is not work

[ntduan]

For api-observable, I try unsubscribe bestNumber, but it not send chain_unsubscribeNewHead request

[ntduan]

ReactiveX/rxjs#3336
I think wo can use publishReplay and refCount

[jacogr]

Yes, I'm suprised it doesn't work, but at the same time it has not seen unsubscribe testing in a very, very long while and a lot of changes has gone into it since it was known working. (There really should be tests around this, that is a failing here)

So the state of the RxJS versions -

1. We are generally trying to point people towards api/rx, hence the documentation all around that
2. api-observable is what the UI uses, but it still needs a bit of TLC to get it nicely aligned with where everything else is now, i.e.

• it doesn't quite extend from api/rx like it should
• really should only have the functions which are not available in the base, i.e. things like combines (and bestNumber is actually a good example of useful things in there since it takes another sub and then pulls info from it)

With all the above background, the fix should indeed go into the rpc-rx package (as indicated above) - so it pulls into both the above mentioned uses.

[jacogr]

So reading through the linked issue, def. seems we introduced this very recently when swapping from BehaviourSubject to ReplaySubject. (Unless the former also has the issue).

I've followed your suggested approach and it seems to do the trick with a test, i.e. unsub seems to be called in this case - #373

[polkadot-js-bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.