Don't add unnecessary methods to virtual tables #3663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanTAllen
force-pushed
the
benoit-1917
branch
from
e608b04 to
f5bfe6d
Compare
Methods are now only added to virtual tables when they can actually be called through a trait. This allows the compiler to generate smaller and more compact virtual tables. This work was originally done by Benoit in PR #1917
SeanTAllen
force-pushed
the
benoit-1917
branch
from
f5bfe6d to
86ca316
Compare
|
@jemc given how old this is and how long it has been open, I think we should close this PR. Thoughts? |
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods are now only added to virtual tables when they can actually
be called through a trait. This allows the compiler to generate
smaller and more compact virtual tables.
This work was originally done by Benoit in PR #1917