Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should remove asgiref run-time dependency #1178

Closed
wch opened this issue Mar 4, 2024 · 0 comments · Fixed by #1183
Closed

Should remove asgiref run-time dependency #1178

wch opened this issue Mar 4, 2024 · 0 comments · Fixed by #1183
Milestone
v0.9.0

Comments

@wch
Copy link
Collaborator

wch commented Mar 4, 2024

The asgiref package is used only for types in

py-shiny/shiny/_autoreload.py

Lines 14 to 21 in b458c35

from asgiref.typing import (
ASGI3Application,
ASGIReceiveCallable,
ASGISendCallable,
ASGISendEvent,
HTTPResponseStartEvent,
Scope,
)

Since it's not used for anything at run-time, we should remove the run-time dependency and also only import in that file if TYPE_CHECKING.
@wch wch added this to the v0.9.0 milestone Mar 4, 2024
@wch wch mentioned this issue Mar 4, 2024
Merged
@wch wch closed this as completed in #1183 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

Remove asgiref run-time dependency posit-dev/py-shiny
1 participant
@wch