Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no gzip for js bundles #334

Closed
KatSick opened this issue Aug 22, 2017 · 8 comments
Closed

There is no gzip for js bundles #334

KatSick opened this issue Aug 22, 2017 · 8 comments

Comments

@KatSick
Copy link

KatSick commented Aug 22, 2017

Do you want to request a feature or report a bug?
Feature

What is the current behavior?
No gzip on js files

If the current behavior is a bug, please provide the steps to reproduce.
Setup project with preact-cli 1.4.1. Open localhost:8080 and check the network tab in Chrome

What is the expected behavior?
Gzip enabled

Please mention other relevant information.

  • node version (8.2.1)
  • npm version (5.3.0)
  • Operating system (Mac OS 10.12.6)
@reznord
Copy link
Member

reznord commented Aug 22, 2017

As of now we are not compressing the js bundle. Probably we add an option to the build command so the use can choose if he wants gzipping or not.

/cc @kristoferbaxter @developit

@developit
Copy link
Member

inb4 we should also do brotli

@reznord
Copy link
Member

reznord commented Aug 22, 2017

We have the option of using Zopfli as well. @kristoferbaxter can give more insights on this.

@thangngoc89
Copy link
Collaborator

My 2 cents:

  • Need to compress the output at build step: messing with native dependencies, probably means lots of new issues.
  • We need to change simplehttp2server /superstatic to something production ready so that users can run npm run serve

@developit
Copy link
Member

I don't think there's an h2 alternative for simplehttp2server, but we could use serve instead of superstatic. I think they might be looking into supporting the same config format?

@reznord
Copy link
Member

reznord commented Jan 17, 2018

We can go with zopfli + brotli for this.

@thangngoc89
Copy link
Collaborator

thangngoc89 commented Jan 17, 2018

COnsider using wasm version (if any) instead of the native C version. It would save everyone a tons of time

@kristoferbaxter
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants