dangerouslySetInnerHTML={undefined} throws

[birtles]

The type of dangerouslySetInnerHTML is:

dangerouslySetInnerHTML?: {
  __html: string;
};

However, when setting dangerouslySetInnerHTML to undefined I hit this code here:

preact-render-to-string/src/index.js

Lines 122 to 135 in c8e54a1

	if (Array.isArray(rendered)) {
	let count = 0;
	let resolved = rendered;
	// Resolving nested Promises with a maximum depth of 25
	while (
	resolved.some((element) => typeof element.then === 'function') &&
	count++ < 25
	) {
	resolved = (await Promise.all(resolved)).flat();
	}
	return resolved.join('');
	}

Here element is undefined and I get Cannot read properties of undefined (reading 'then').

Using typeof element?.then === 'function' seems to fix it for me.

[marvinhagemeister]

I'm not able to reproduce the described error on my end. Are you on the latest version? Can you share a snippet that reproduces the error for you?

[birtles]

Oh, sorry about that. I was hitting this via Astro's Preact package and it seemed to come from this changeset: withastro/astro#11464

I'll see if I can work out what is going on when I get a chance.

[rschristian]

Thanks, I can reproduce & got a PR created.

I think Marvin was assuming renderToString, rather than renderToStringAsync, as there wasn't any mention of method (well, other than the code block showing async's internals)