-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow users to opt out of compat aliases #79
Conversation
src/index.ts
Outdated
* Whether to use preact/compat aliases | ||
* @default true | ||
*/ | ||
compatAliasesEnabled?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, preactCompatAliasesEnabled
? Not sure what's best, open to suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also be fine with reactAliases: boolean
since it's shorter. Technically we're not aliasing compat to something but rather react to compat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true. I suppose we could also go compatEnabled
; the end user is probably just looking at enabling/disabling compat, do they need to know it's done via aliases? Just a thought.
I do like having ...Enabled
in the name, though -- matches the prefresh & devtools options and is also a bit more obvious that it's a boolean from a naming perspective.
02efaf0
to
b691ac3
Compare
b691ac3
to
5136e05
Compare
Hi, how would I be able to get ahold of this? The latest version is 2.5.0 which was released before this change went in. I'm also not seeing a pre-release version? Thanks! |
@jschuler You can patch your |
Closes #78