Revert "Use ESM entrypoint for require(ESM)"
#17156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b64b0a8.
|
Size Change: -699 B (-0.01%) Total Size: 7.89 MB
ℹ️ View Unchanged
|
commit: |
|
As tested, this also fixes shufo/prettier-plugin-blade#311 |
|
I haven't got enough information from prettier/plugin-php#2418, but shufo/prettier-plugin-blade#311 products the same error. |
|
I'm going to merge this and release a patch. |
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 22, 2025
| datasource | package | from | to | | ---------- | -------- | ----- | ----- | | npm | prettier | 3.5.1 | 3.5.2 | ## [v3.5.2](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#352) [diff](prettier/prettier@3.5.1...3.5.2) ##### Remove `module-sync` condition ([#17156](prettier/prettier#17156) by [@fisker](https://github.com/fisker)) In Prettier 3.5.0, [we added `module-sync` condition to `package.json`](https://prettier.io/blog/2025/02/09/3.5.0#use-esm-entrypoint-for-requireesm-16958-by-tats-u), so that `require("prettier")` can use ESM version, but turns out it doesn't work if CommonJS and ESM plugins both imports builtin plugins. To solve this problem, we decide simply remove the `module-sync` condition, so `require("prettier")` will still use the CommonJS version, we'll revisit until `require(ESM)` feature is more stable.
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 23, 2025
| datasource | package | from | to | | ---------- | -------- | ----- | ----- | | npm | prettier | 3.5.1 | 3.5.2 | ## [v3.5.2](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#352) [diff](prettier/prettier@3.5.1...3.5.2) ##### Remove `module-sync` condition ([#17156](prettier/prettier#17156) by [@fisker](https://github.com/fisker)) In Prettier 3.5.0, [we added `module-sync` condition to `package.json`](https://prettier.io/blog/2025/02/09/3.5.0#use-esm-entrypoint-for-requireesm-16958-by-tats-u), so that `require("prettier")` can use ESM version, but turns out it doesn't work if CommonJS and ESM plugins both imports builtin plugins. To solve this problem, we decide simply remove the `module-sync` condition, so `require("prettier")` will still use the CommonJS version, we'll revisit until `require(ESM)` feature is more stable.
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 26, 2025
| datasource | package | from | to | | ---------- | -------- | ----- | ----- | | npm | prettier | 3.5.1 | 3.5.2 | ## [v3.5.2](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#352) [diff](prettier/prettier@3.5.1...3.5.2) ##### Remove `module-sync` condition ([#17156](prettier/prettier#17156) by [@fisker](https://github.com/fisker)) In Prettier 3.5.0, [we added `module-sync` condition to `package.json`](https://prettier.io/blog/2025/02/09/3.5.0#use-esm-entrypoint-for-requireesm-16958-by-tats-u), so that `require("prettier")` can use ESM version, but turns out it doesn't work if CommonJS and ESM plugins both imports builtin plugins. To solve this problem, we decide simply remove the `module-sync` condition, so `require("prettier")` will still use the CommonJS version, we'll revisit until `require(ESM)` feature is more stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #16958
Fixes #17139
@tats-u