Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DataScroller for Performance and Fix Lazy Loading #3906

Closed
burner-account opened this issue Sep 12, 2017 · 4 comments
Closed

Refactor DataScroller for Performance and Fix Lazy Loading #3906

burner-account opened this issue Sep 12, 2017 · 4 comments
Assignees
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@burner-account
Copy link

Request: There is no guarantee in receiving a response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeNG PRO Support where support is provided within 4 business hours

Response: I am currently test driving PrimeNG. I am not yet convinced, that we should buy support for this product. I can't even tell if your request is legit or fishy. Is it a hint, a warning or a threat?

I'm submitting a ... (check one with "x")

[ x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
If the datascroller fires a lazy load event, it assumes an instantaneous, successful lazy load happens, thus immediately incrementing "this.first = this.first + this.rows;".
Since there is no way to unbind the lazy load event while lazy loading, a normal scroll finger movement will fire huge amounts of lazy load events... while the lazy load event you actually care about is not yet finished.

Expected behavior
Maybe allow deactiving the lazy load event while lazy loading. Seriously. Is there any use case in which in the current behaviour is required or useful? What do i miss?

@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Status: Pending Review Issue or pull request is being reviewed by Core Team labels Oct 20, 2017
@cagataycivici cagataycivici added this to the 4.3.0 milestone Oct 20, 2017
@Bohdan-Tereta
Copy link

Bohdan-Tereta commented Dec 16, 2017

Had a similiar issue, and fixed that, see my pull request #4676.

Please check and merge if you'd like.

@cagataycivici cagataycivici removed this from the 5.FUTURE milestone Jan 15, 2018
@cagataycivici cagataycivici added confirmed and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jan 22, 2018
@cagataycivici cagataycivici self-assigned this Jan 22, 2018
@cagataycivici cagataycivici added this to the 5.2.0-RC2 milestone Jan 22, 2018
@cagataycivici cagataycivici changed the title Datascroller lazy load implementation broken VirtualScroll for DataScroller Jan 23, 2018
@cagataycivici cagataycivici added Type: New Feature Issue contains a new feature or new component request and removed confirmed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Jan 23, 2018
@cagataycivici cagataycivici modified the milestones: 5.2.0-RC2, 5.2.0-RC3 Jan 23, 2018
@cagataycivici
Copy link
Member

We'll implement virtual scroll for lazy mode.

@cagataycivici cagataycivici changed the title VirtualScroll for DataScroller Refactor DataScroller for Performance and Fix Lazy Loading Jan 30, 2018
@mroskamp
Copy link
Contributor

mroskamp commented Mar 28, 2018

@cagataycivici I'm still running into this issue in v5.2.4. Here's a plnkr where I introduce a 250 ms timeout before loading the next page of results, which illustrates the issue: http://plnkr.co/edit/5EyojPuaoLg9ox5olk4z?p=preview

@jonbarthol
Copy link

jonbarthol commented May 29, 2018

The Plunkr example posted by @mroskamp may not load. Here's the same example on StackBlitz:
https://datascroller-bug.stackblitz.io

I opened a new issue: #5816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

No branches or pull requests

5 participants