Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown filter has incorrect width under fluid mode #4067

Closed
bossqone opened this issue Oct 1, 2017 · 3 comments
Closed

Dropdown filter has incorrect width under fluid mode #4067

bossqone opened this issue Oct 1, 2017 · 3 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@bossqone
Copy link
Contributor

bossqone commented Oct 1, 2017

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
http://plnkr.co/edit/UcMvApArFWvDAgaxxmF5?p=preview

Current behavior
With [autoWidth]=false and fluid layout, filter doesn't take full width of it's container.
screenshot of issue in Poseidon theme

Expected behavior
Filter should take full width of it's container.

  • PrimeNG version: 4.2.1
@Merve7 Merve7 self-assigned this Oct 2, 2017
@Merve7 Merve7 added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 2, 2017
@Merve7 Merve7 added this to the 4.2.2 milestone Oct 2, 2017
@Merve7 Merve7 closed this as completed in ff982aa Oct 2, 2017
@bossqone
Copy link
Contributor Author

bossqone commented Oct 2, 2017

@Merve7 Hi, I saw your fix and I have a question. How it behaves when style param is not defined? Do I need to specify style.width everytime I want to use dropdown component?

Could you please provide an example of usage? Thank you.

@cagataycivici cagataycivici changed the title Dropdown filter has incorrect width Dropdown filter has incorrect width under fluid mode Oct 2, 2017
@cagataycivici
Copy link
Member

style.width is a problem, it will throw an exception, I have to revert it.

@cagataycivici cagataycivici reopened this Oct 2, 2017
@cagataycivici
Copy link
Member

Removed style.width binding and merged the PR to fix this, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants