Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve charts responsiveness #4577

Closed
AndreaBarbasso opened this issue Nov 30, 2017 · 1 comment
Closed

Improve charts responsiveness #4577

AndreaBarbasso opened this issue Nov 30, 2017 · 1 comment
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@AndreaBarbasso
Copy link
Contributor

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
No need to have a plunker, just look at Ultima's Charts page.

Current behavior
If you collapse the left-hand menu charts are not drawn again in their new size, as they only traslate position. This is a breaking behaviour when they should reduce size.
Breaking behaviour

This is easily achieavable by setting the canvas wrapper position as relative as seen on chartjs docs.

Expected behavior
Charts should follow their parent's resizing.

Minimal reproduction of the problem with instructions

  • Go on Ultima's Charts page, resize menu, look at charts staying the same.
  • Go to any other page, change menu type to Overlay.
  • Go back to Charts page, change menu back to static. Look at charts overflowing.
@AndreaBarbasso
Copy link
Contributor Author

I wanted to set up a PR with the given fix, though it's not enough. If resizing is done with an animation, the performance is horrible.

@cagataycivici cagataycivici self-assigned this Dec 19, 2017
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 19, 2017
@cagataycivici cagataycivici added this to the 5.1.0-M1 milestone Dec 19, 2017
@cagataycivici cagataycivici changed the title Unresponsive charts when non-window resizing events are fired Improve charts responsiveness Dec 19, 2017
@cagataycivici cagataycivici added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants