Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document cibuild and release scripts, make them testable #274

Closed
shawnbot opened this issue Jul 25, 2017 · 1 comment
Closed

Document cibuild and release scripts, make them testable #274

shawnbot opened this issue Jul 25, 2017 · 1 comment
Assignees

Comments

@shawnbot
Copy link
Contributor

The cibuild and release scripts (release, release-candidate, and release-pr) need some more descriptive comments of what's happening in them so that we can reason about them when reviewing changes. It'd also be nice to either have docs for how to test them locally or actually make them testable locally, i.e. in some way that they don't actually publish to npm when they're not running on Travis unless you explicitly tell them to. (Alternatively, there could be some sort of --dry-run-like option that they could recognize, which would skip or otherwise disable the publish step.)

This might also be a good place to describe the release logic that happens on Travis in a more human-readable way. 🤓 🤖

@shawnbot
Copy link
Contributor Author

These scripts are dramatically simplified as of #625, so there shouldn't be any need to document them or make them testable on their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant