Skip to content
This repository has been archived by the owner on Mar 31, 2020. It is now read-only.

Deprecate this action 💀 #18

Closed
2 of 8 tasks
shawnbot opened this issue Jun 20, 2019 · 0 comments
Closed
2 of 8 tasks

Deprecate this action 💀 #18

shawnbot opened this issue Jun 20, 2019 · 0 comments
Assignees

Comments

@shawnbot
Copy link
Contributor

A lot has changed with Now's GitHub integration since we made this action, and it does all of the things we do. As we migrate our repos from Now v1 to v2, we need to also remove this action from our workflows and add them to the list in our installed app settings. Here's the playbook for migrating:

  1. Add the repo in the Now app settings (private, behind sudo auth).
  2. Delete any actions with uses = "primer/deploy@..." in .github/main.workflow, and remove that action's name from any needs = [...] prerequisites in other actions.
  3. Commit those changes to a new branch and create a PR so that you can see what happens and fix any issues that come up.

That should be it! If all goes well, you'll get a comment from now[bot] with a link to the deployment. If the repo you're updating is on Now v2 (if it has version: 2 in now.json), you'll get an alias URL for the most recent deployment in the form {project}-git-{branch}.primer.now.sh. ✨

Note that migration URLs are still available in the status checks list for each push, but the integration uses our Deployments API and closes #7.

Repos to migrate

Docs to update

  • primer/actions (this repo can probably be deleted if we're only using primer/publish everywhere)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants