Fix #258: Allow escaping pipes within tables #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix quantizor#258 A port of ariabuckles/simple-markdown@f32a628 to markdown-to-jsx. Previously, tables were parsed using String.prototype.split on pipe (`|`) characters. This commit changes table parsing to use a full parse() call, using a new `tableSeparator` rule to match tableSeparators. Because `tableSeparator` is now a rule, the `escapedText` rule can handle escaped pipes within the table, and the `codeInline` rule can handle inline code with pipes in it. Test plan: Added tests to index.compiler.spec.js
This was referenced Aug 5, 2019
|
Thanks for this @ariabuckles! I'll take a look in the next day or two, really appreciate the contribution ❤️ |
|
Thanks for taking a look @probablyup ! |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #258
A port of ariabuckles/simple-markdown@f32a628
to markdown-to-jsx.
Previously, tables were parsed using String.prototype.split on pipe
(
|) characters.This PR changes table parsing to use a full parse() call, using a
new
tableSeparatorrule to match tableSeparators. BecausetableSeparatoris now a rule, theescapedTextrule can handleescaped pipes within the table, and the
codeInlinerule can handleinline code with pipes in it.
Test plan:
Added tests to index.compiler.spec.js