Skip to content
This repository has been archived by the owner on Feb 20, 2024. It is now read-only.

Start with a label element instead of data-label attribute #3

Closed
zachleat opened this issue Dec 3, 2013 · 3 comments
Closed

Start with a label element instead of data-label attribute #3

zachleat opened this issue Dec 3, 2013 · 3 comments

Comments

@zachleat
Copy link

zachleat commented Dec 3, 2013

It’s better for accessibility and progressive enhancement if you start with a label element instead of dynamically creating one from a data-label with JS.
@joahg joahg mentioned this issue Dec 3, 2013
Closed
@zachleat
Copy link
Author

zachleat commented Dec 3, 2013

Whoa, nice work @joahg!

@joahg
Copy link

joahg commented Dec 3, 2013

Thanks @zachleat :)

@joahg joahg mentioned this issue Dec 3, 2013
Closed
@derpoho
Copy link
Collaborator

derpoho commented Dec 8, 2013

Will update the script. But not with this PR because i want to keep both options. either label or data-label.

Thx for your suggestion!

@derpoho derpoho closed this as completed Dec 8, 2013
@derpoho derpoho mentioned this issue Dec 8, 2013
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zachleat @derpoho @joahg