You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the following works with the default config:
My new change.
Change-Type: patch
My-Unknown-Tag: dog
versionist will pick up the semver value and use this in versioning up.
However, the following does not work:
My new change.
Change-Type: patch
This is the final line of the footer.
My current assumption is that if versionist doesn't see only a set of key/value tags in a footer, it'll decide the footer is a body.
We don't stringently define the footer as only key/value pairs in the commit/PR doc, so we either need to or, I think more sensibly, allow anything in the footer as long as the relevant tags exist there.
The text was updated successfully, but these errors were encountered:
But OTOH if you're allowing non-tagged entries in the footer, does it even make sense to talk about the 'footer' at all? Could the Change-Type: line end up being at any location in the commit message?
No, the main reason for allowing this is to use the 'Signed off' feature of git. I would not expect generic messages in the footer. Having the tags in the footer mean we know exactly where to look for them.
I should probably have been more explicit, but I can foresee other tools adding info messages to the bottom of a commit. :-)
Currently, the following works with the default config:
versionist
will pick up the semver value and use this in versioning up.However, the following does not work:
My current assumption is that if
versionist
doesn't see only a set of key/value tags in a footer, it'll decide the footer is a body.We don't stringently define the footer as only key/value pairs in the commit/PR doc, so we either need to or, I think more sensibly, allow anything in the footer as long as the relevant tags exist there.
The text was updated successfully, but these errors were encountered: