Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any non-tag footer entries will result in versionist failing to find the tags. #75

Open
hedss opened this issue Feb 27, 2017 · 2 comments

Comments

@hedss
Copy link
Contributor

hedss commented Feb 27, 2017

Currently, the following works with the default config:

My new change.

Change-Type: patch
My-Unknown-Tag: dog

versionist will pick up the semver value and use this in versioning up.

However, the following does not work:

My new change.

Change-Type: patch
This is the final line of the footer.

My current assumption is that if versionist doesn't see only a set of key/value tags in a footer, it'll decide the footer is a body.
We don't stringently define the footer as only key/value pairs in the commit/PR doc, so we either need to or, I think more sensibly, allow anything in the footer as long as the relevant tags exist there.

@lurch
Copy link
Contributor

lurch commented Feb 27, 2017

But OTOH if you're allowing non-tagged entries in the footer, does it even make sense to talk about the 'footer' at all? Could the Change-Type: line end up being at any location in the commit message?

@hedss
Copy link
Contributor Author

hedss commented Feb 27, 2017

No, the main reason for allowing this is to use the 'Signed off' feature of git. I would not expect generic messages in the footer. Having the tags in the footer mean we know exactly where to look for them.
I should probably have been more explicit, but I can foresee other tools adding info messages to the bottom of a commit. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants