Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requires an API interface to drive directly as a module #83

Open
hedss opened this issue May 15, 2017 · 1 comment
Open

Requires an API interface to drive directly as a module #83

hedss opened this issue May 15, 2017 · 1 comment
Labels
enhancement priority/high

Comments

@hedss
Copy link
Contributor

hedss commented May 15, 2017

VersionBot calls versionist as an executable. This is not ideal, as there are instances where we would like to pass different options around.
@hedss hedss mentioned this issue May 15, 2017
Open
@hedss hedss mentioned this issue Oct 16, 2017
Open
dt-rush pushed a commit to dt-rush/versionist that referenced this issue Aug 12, 2018
separating out a programmatic interface from the CLI code
fa8d94b 
Change-Type: minor
Connects-to: product-os#83
@dt-rush dt-rush mentioned this issue Aug 12, 2018
Closed
@dt-rush
Copy link

dt-rush commented Aug 12, 2018 •
edited
Loading

Hey folks,

I took some time out yesterday and this morning to work on this. It was quite a bit of a task to cut it free, but I've done it. It's now callable via am exported function (see the README of my branch). All tests are passing and it just needs a look-over.

Ideally, over time, we could make the tool return more output depending on what it did, but for now, it returns the same output it did before, simply in the .then() param instead of directly to stdout, and sends any errors to .catch() instead of to stderr.

dt-rush pushed a commit that referenced this issue Mar 28, 2019
@dt-rush
separating out a programmatic interface from the CLI code
b5bd92f 
Change-Type: minor
Connects-to: #83
Signed-off-by: Nick Payne<[email protected]>
@dt-rush dt-rush mentioned this issue Mar 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement priority/high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hedss @dt-rush