From c23ba563138378fa9ab22bb9e91e46a912df298f Mon Sep 17 00:00:00 2001 From: Jarrett Andrulis Date: Wed, 8 Sep 2021 14:43:54 -0500 Subject: [PATCH 1/6] commit --- checks/randomFile.txt | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 checks/randomFile.txt diff --git a/checks/randomFile.txt b/checks/randomFile.txt new file mode 100644 index 0000000000..e69de29bb2 From 397a44e3f96090826d0379e86fa0e2827e1dc2e5 Mon Sep 17 00:00:00 2001 From: Jarrett Andrulis Date: Mon, 20 Sep 2021 10:14:45 -0500 Subject: [PATCH 2/6] Adding check_extra7151 --- checks/check_extra7151 | 53 ++++++++++++++++++++++++++++++++++++++++++ groups/group7_extras | 2 +- 2 files changed, 54 insertions(+), 1 deletion(-) create mode 100644 checks/check_extra7151 diff --git a/checks/check_extra7151 b/checks/check_extra7151 new file mode 100644 index 0000000000..522f2ee382 --- /dev/null +++ b/checks/check_extra7151 @@ -0,0 +1,53 @@ +#!/usr/bin/env bash + +# Prowler - the handy cloud security tool (copyright 2019) by Toni de la Fuente +# +# Licensed under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy +# of the License at http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software distributed +# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR +# CONDITIONS OF ANY KIND, either express or implied. See the License for the +# specific language governing permissions and limitations under the License. + +# Remediation: +# +# https://docs.aws.amazon.com/cli/latest/reference/route53domains/update-domain-contact-privacy.html +# +# update-domain-contact-privacy \ +# --region us-east-1 \ +# --domain-name example.com \ +# --admin-privacy \ +# --registrant-privacy \ +# --tech-privacy + +CHECK_ID_extra7151="7.151" +CHECK_TITLE_extra7151="[extra7151] Enable Privacy Protection for domain contact information" +CHECK_SCORED_extra7151="NOT_SCORED" +CHECK_TYPE_extra7151="EXTRA" +CHECK_SEVERITY_extra7151="Medium" +CHECK_ASFF_RESOURCE_TYPE_extra7151="AwsRoute53Domain" +CHECK_ALTERNATE_check7151="extra7151" +CHECK_SERVICENAME_extra7151="route53" +CHECK_RISK_extra7151='Without privacy protection enabled, ones personal information is published to the public WHOIS database' +CHECK_REMEDIATION_extra7151='Ensure default VPC is deleted' +CHECK_DOC_extra7151='https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/domain-privacy-protection.html' +CHECK_CAF_EPIC_extra7151='Data Protection' + +extra7151(){ + echo "Route53 is a global service, looking for domains in US-EAST-1" + DOMAIN_NAMES=$($AWSCLI route53domains list-domains $PROFILE_OPT --region us-east-1 --query 'Domains[*].DomainName' --output text ) + if [[ $DOMAIN_NAMES ]];then + for domain_name in $DOMAIN_NAMES;do + DOMAIN_DETAIL=$($AWSCLI route53domains get-domain-detail $PROFILE_OPT --region us-east-1 --query 'AdminPrivacy' --domain-name $domain_name) + if [[ $DOMAIN_DETAIL == false ]]; then + textFail "$regx: Contact information public for: $domain_name" "$regx" "$domain_name" + else + textPass "$regx: All contact information is private for: $domain_name" "$regx" "$domain_name" + fi + done + else + textPass "$regx: No Domain Names found" "$regx" + fi +} diff --git a/groups/group7_extras b/groups/group7_extras index 5c2b7010bd..877c512af8 100644 --- a/groups/group7_extras +++ b/groups/group7_extras @@ -15,7 +15,7 @@ GROUP_ID[7]='extras' GROUP_NUMBER[7]='7.0' GROUP_TITLE[7]='Extras - all non CIS specific checks - [extras] ****************' GROUP_RUN_BY_DEFAULT[7]='Y' # run it when execute_all is called -GROUP_CHECKS[7]='extra71,extra72,extra73,extra74,extra75,extra76,extra77,extra78,extra79,extra710,extra711,extra712,extra713,extra714,extra715,extra716,extra717,extra718,extra719,extra720,extra721,extra722,extra723,extra724,extra725,extra726,extra727,extra728,extra729,extra730,extra731,extra732,extra733,extra734,extra735,extra736,extra738,extra739,extra740,extra741,extra742,extra743,extra744,extra745,extra746,extra747,extra748,extra749,extra750,extra751,extra752,extra753,extra754,extra755,extra757,extra758,extra761,extra762,extra763,extra764,extra765,extra767,extra768,extra769,extra770,extra771,extra772,extra773,extra774,extra775,extra776,extra777,extra778,extra779,extra780,extra781,extra782,extra783,extra784,extra785,extra786,extra787,extra788,extra791,extra792,extra793,extra794,extra795,extra796,extra797,extra798,extra799,extra7100,extra7101,extra7102,extra7103,extra7104,extra7105,extra7106,extra7107,extra7108,extra7109,extra7110,extra7111,extra7112,extra7113,extra7114,extra7115,extra7116,extra7117,extra7118,extra7119,extra7120,extra7121,extra7122,extra7123,extra7124,extra7125,extra7126,extra7127,extra7128,extra7129,extra7130,extra7131,extra7132,extra7133,extra7134,extra7135,extra7136,extra7137,extra7138,extra7139,extra7140,extra7141,extra7142,extra7143,extra7144,extra7145,extra7146,extra7147' +GROUP_CHECKS[7]='extra71,extra72,extra73,extra74,extra75,extra76,extra77,extra78,extra79,extra710,extra711,extra712,extra713,extra714,extra715,extra716,extra717,extra718,extra719,extra720,extra721,extra722,extra723,extra724,extra725,extra726,extra727,extra728,extra729,extra730,extra731,extra732,extra733,extra734,extra735,extra736,extra738,extra739,extra740,extra741,extra742,extra743,extra744,extra745,extra746,extra747,extra748,extra749,extra750,extra751,extra752,extra753,extra754,extra755,extra757,extra758,extra761,extra762,extra763,extra764,extra765,extra767,extra768,extra769,extra770,extra771,extra772,extra773,extra774,extra775,extra776,extra777,extra778,extra779,extra780,extra781,extra782,extra783,extra784,extra785,extra786,extra787,extra788,extra791,extra792,extra793,extra794,extra795,extra796,extra797,extra798,extra799,extra7100,extra7101,extra7102,extra7103,extra7104,extra7105,extra7106,extra7107,extra7108,extra7109,extra7110,extra7111,extra7112,extra7113,extra7114,extra7115,extra7116,extra7117,extra7118,extra7119,extra7120,extra7121,extra7122,extra7123,extra7124,extra7125,extra7126,extra7127,extra7128,extra7129,extra7130,extra7131,extra7132,extra7133,extra7134,extra7135,extra7136,extra7137,extra7138,extra7139,extra7140,extra7141,extra7142,extra7143,extra7144,extra7145,extra7146,extra7147,extra7151' # Extras 759 and 760 (lambda variables and code secrets finder are not included) # to run detect-secrets use `./prowler -g secrets` From 6566e80a3c6a2ab7c8cfdb695acc3a737ecc6654 Mon Sep 17 00:00:00 2001 From: Jarrett Andrulis Date: Mon, 20 Sep 2021 10:59:30 -0500 Subject: [PATCH 3/6] renamed as extra7152 --- checks/{check_extra7151 => check_extra7152} | 26 ++++++++++----------- groups/group7_extras | 2 +- 2 files changed, 14 insertions(+), 14 deletions(-) rename checks/{check_extra7151 => check_extra7152} (76%) diff --git a/checks/check_extra7151 b/checks/check_extra7152 similarity index 76% rename from checks/check_extra7151 rename to checks/check_extra7152 index 522f2ee382..01dee96036 100644 --- a/checks/check_extra7151 +++ b/checks/check_extra7152 @@ -22,20 +22,20 @@ # --registrant-privacy \ # --tech-privacy -CHECK_ID_extra7151="7.151" -CHECK_TITLE_extra7151="[extra7151] Enable Privacy Protection for domain contact information" -CHECK_SCORED_extra7151="NOT_SCORED" -CHECK_TYPE_extra7151="EXTRA" -CHECK_SEVERITY_extra7151="Medium" -CHECK_ASFF_RESOURCE_TYPE_extra7151="AwsRoute53Domain" -CHECK_ALTERNATE_check7151="extra7151" -CHECK_SERVICENAME_extra7151="route53" -CHECK_RISK_extra7151='Without privacy protection enabled, ones personal information is published to the public WHOIS database' -CHECK_REMEDIATION_extra7151='Ensure default VPC is deleted' -CHECK_DOC_extra7151='https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/domain-privacy-protection.html' -CHECK_CAF_EPIC_extra7151='Data Protection' +CHECK_ID_extra7152="7.152" +CHECK_TITLE_extra7152="[extra7152] Enable Privacy Protection for domain contact information" +CHECK_SCORED_extra7152="NOT_SCORED" +CHECK_TYPE_extra7152="EXTRA" +CHECK_SEVERITY_extra7152="Medium" +CHECK_ASFF_RESOURCE_TYPE_extra7152="AwsRoute53Domain" +CHECK_ALTERNATE_check7152="extra7152" +CHECK_SERVICENAME_extra7152="route53" +CHECK_RISK_extra7152='Without privacy protection enabled, ones personal information is published to the public WHOIS database' +CHECK_REMEDIATION_extra7152='Ensure default Privacy is enabled' +CHECK_DOC_extra7152='https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/domain-privacy-protection.html' +CHECK_CAF_EPIC_extra7152='Data Protection' -extra7151(){ +extra7152(){ echo "Route53 is a global service, looking for domains in US-EAST-1" DOMAIN_NAMES=$($AWSCLI route53domains list-domains $PROFILE_OPT --region us-east-1 --query 'Domains[*].DomainName' --output text ) if [[ $DOMAIN_NAMES ]];then diff --git a/groups/group7_extras b/groups/group7_extras index 877c512af8..d99b42cdb6 100644 --- a/groups/group7_extras +++ b/groups/group7_extras @@ -15,7 +15,7 @@ GROUP_ID[7]='extras' GROUP_NUMBER[7]='7.0' GROUP_TITLE[7]='Extras - all non CIS specific checks - [extras] ****************' GROUP_RUN_BY_DEFAULT[7]='Y' # run it when execute_all is called -GROUP_CHECKS[7]='extra71,extra72,extra73,extra74,extra75,extra76,extra77,extra78,extra79,extra710,extra711,extra712,extra713,extra714,extra715,extra716,extra717,extra718,extra719,extra720,extra721,extra722,extra723,extra724,extra725,extra726,extra727,extra728,extra729,extra730,extra731,extra732,extra733,extra734,extra735,extra736,extra738,extra739,extra740,extra741,extra742,extra743,extra744,extra745,extra746,extra747,extra748,extra749,extra750,extra751,extra752,extra753,extra754,extra755,extra757,extra758,extra761,extra762,extra763,extra764,extra765,extra767,extra768,extra769,extra770,extra771,extra772,extra773,extra774,extra775,extra776,extra777,extra778,extra779,extra780,extra781,extra782,extra783,extra784,extra785,extra786,extra787,extra788,extra791,extra792,extra793,extra794,extra795,extra796,extra797,extra798,extra799,extra7100,extra7101,extra7102,extra7103,extra7104,extra7105,extra7106,extra7107,extra7108,extra7109,extra7110,extra7111,extra7112,extra7113,extra7114,extra7115,extra7116,extra7117,extra7118,extra7119,extra7120,extra7121,extra7122,extra7123,extra7124,extra7125,extra7126,extra7127,extra7128,extra7129,extra7130,extra7131,extra7132,extra7133,extra7134,extra7135,extra7136,extra7137,extra7138,extra7139,extra7140,extra7141,extra7142,extra7143,extra7144,extra7145,extra7146,extra7147,extra7151' +GROUP_CHECKS[7]='extra71,extra72,extra73,extra74,extra75,extra76,extra77,extra78,extra79,extra710,extra711,extra712,extra713,extra714,extra715,extra716,extra717,extra718,extra719,extra720,extra721,extra722,extra723,extra724,extra725,extra726,extra727,extra728,extra729,extra730,extra731,extra732,extra733,extra734,extra735,extra736,extra738,extra739,extra740,extra741,extra742,extra743,extra744,extra745,extra746,extra747,extra748,extra749,extra750,extra751,extra752,extra753,extra754,extra755,extra757,extra758,extra761,extra762,extra763,extra764,extra765,extra767,extra768,extra769,extra770,extra771,extra772,extra773,extra774,extra775,extra776,extra777,extra778,extra779,extra780,extra781,extra782,extra783,extra784,extra785,extra786,extra787,extra788,extra791,extra792,extra793,extra794,extra795,extra796,extra797,extra798,extra799,extra7100,extra7101,extra7102,extra7103,extra7104,extra7105,extra7106,extra7107,extra7108,extra7109,extra7110,extra7111,extra7112,extra7113,extra7114,extra7115,extra7116,extra7117,extra7118,extra7119,extra7120,extra7121,extra7122,extra7123,extra7124,extra7125,extra7126,extra7127,extra7128,extra7129,extra7130,extra7131,extra7132,extra7133,extra7134,extra7135,extra7136,extra7137,extra7138,extra7139,extra7140,extra7141,extra7142,extra7143,extra7144,extra7145,extra7146,extra7147,extra7152' # Extras 759 and 760 (lambda variables and code secrets finder are not included) # to run detect-secrets use `./prowler -g secrets` From db6363e89f5db0c298fe97bd2e20b9091e937e17 Mon Sep 17 00:00:00 2001 From: Toni de la Fuente Date: Thu, 23 Sep 2021 10:08:03 +0200 Subject: [PATCH 4/6] Delete randomFile.txt --- checks/randomFile.txt | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 checks/randomFile.txt diff --git a/checks/randomFile.txt b/checks/randomFile.txt deleted file mode 100644 index e69de29bb2..0000000000 From e4ecbcbd54b47327cb3465702c5adbcd7f4fa83c Mon Sep 17 00:00:00 2001 From: Toni de la Fuente Date: Thu, 23 Sep 2021 10:08:26 +0200 Subject: [PATCH 5/6] Delete group7_extras --- groups/group7_extras | 27 --------------------------- 1 file changed, 27 deletions(-) delete mode 100644 groups/group7_extras diff --git a/groups/group7_extras b/groups/group7_extras deleted file mode 100644 index d99b42cdb6..0000000000 --- a/groups/group7_extras +++ /dev/null @@ -1,27 +0,0 @@ -#!/usr/bin/env bash - -# Prowler - the handy cloud security tool (copyright 2018) by Toni de la Fuente -# -# Licensed under the Apache License, Version 2.0 (the "License"); you may not -# use this file except in compliance with the License. You may obtain a copy -# of the License at http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software distributed -# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR -# CONDITIONS OF ANY KIND, either express or implied. See the License for the -# specific language governing permissions and limitations under the License. - -GROUP_ID[7]='extras' -GROUP_NUMBER[7]='7.0' -GROUP_TITLE[7]='Extras - all non CIS specific checks - [extras] ****************' -GROUP_RUN_BY_DEFAULT[7]='Y' # run it when execute_all is called -GROUP_CHECKS[7]='extra71,extra72,extra73,extra74,extra75,extra76,extra77,extra78,extra79,extra710,extra711,extra712,extra713,extra714,extra715,extra716,extra717,extra718,extra719,extra720,extra721,extra722,extra723,extra724,extra725,extra726,extra727,extra728,extra729,extra730,extra731,extra732,extra733,extra734,extra735,extra736,extra738,extra739,extra740,extra741,extra742,extra743,extra744,extra745,extra746,extra747,extra748,extra749,extra750,extra751,extra752,extra753,extra754,extra755,extra757,extra758,extra761,extra762,extra763,extra764,extra765,extra767,extra768,extra769,extra770,extra771,extra772,extra773,extra774,extra775,extra776,extra777,extra778,extra779,extra780,extra781,extra782,extra783,extra784,extra785,extra786,extra787,extra788,extra791,extra792,extra793,extra794,extra795,extra796,extra797,extra798,extra799,extra7100,extra7101,extra7102,extra7103,extra7104,extra7105,extra7106,extra7107,extra7108,extra7109,extra7110,extra7111,extra7112,extra7113,extra7114,extra7115,extra7116,extra7117,extra7118,extra7119,extra7120,extra7121,extra7122,extra7123,extra7124,extra7125,extra7126,extra7127,extra7128,extra7129,extra7130,extra7131,extra7132,extra7133,extra7134,extra7135,extra7136,extra7137,extra7138,extra7139,extra7140,extra7141,extra7142,extra7143,extra7144,extra7145,extra7146,extra7147,extra7152' - -# Extras 759 and 760 (lambda variables and code secrets finder are not included) -# to run detect-secrets use `./prowler -g secrets` - -# Extras 789 and 790 VPC trust boundaries are not included by default in Extras -# to run trust-boundaries use `./prowler -g trustboundaries` -# read more in https://github.com/toniblyx/prowler/#trust-boundaries-checks - - From 27ab868e497b1fa4d48546f04b3a95e40af73560 Mon Sep 17 00:00:00 2001 From: Jarrett Andrulis Date: Mon, 4 Oct 2021 15:26:05 -0500 Subject: [PATCH 6/6] Update check_extra7152 --- checks/check_extra7152 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checks/check_extra7152 b/checks/check_extra7152 index 01dee96036..f2a906fdb2 100644 --- a/checks/check_extra7152 +++ b/checks/check_extra7152 @@ -23,7 +23,7 @@ # --tech-privacy CHECK_ID_extra7152="7.152" -CHECK_TITLE_extra7152="[extra7152] Enable Privacy Protection for domain contact information" +CHECK_TITLE_extra7152="[extra7152] Enable Privacy Protection for for a Route53 Domain" CHECK_SCORED_extra7152="NOT_SCORED" CHECK_TYPE_extra7152="EXTRA" CHECK_SEVERITY_extra7152="Medium"