Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NOISE Handshake Fallback to SECIO for P2P #5410

Closed
rauljordan opened this issue Apr 13, 2020 · 4 comments
Closed

Fix NOISE Handshake Fallback to SECIO for P2P #5410

rauljordan opened this issue Apr 13, 2020 · 4 comments
Assignees
@nisdas
Labels
Blocked Blocked by research or external factors Priority: High High priority item
Milestone
Multiclient Readi...

Comments

@rauljordan
Copy link
Contributor

Hi all, currently the NOISE handshake does not consistently fallback to secio for libp2p security. If we want to upgrade our nodes to use Noise, we need to ensure the fallback is fully functional and always works otherwise we risk network partitions.
@rauljordan rauljordan added the Priority: High High priority item label Apr 13, 2020
@rauljordan rauljordan added this to the Multiclient Readiness milestone Apr 13, 2020
@shayzluf
Copy link
Contributor

@rauljordan any update on this issue?

@shayzluf shayzluf added Help Wanted Extra attention is needed and removed Help Wanted Extra attention is needed labels Apr 29, 2020
@shayzluf
Copy link
Contributor

assigned to @nisdas as i think p2p issues owned by you. please reassign to me if you want me to find another assignee

@nisdas
Copy link
Member

nisdas commented Apr 29, 2020

This is currently blocked @shayzluf
libp2p/go-libp2p-noise#70

@nisdas nisdas added the Blocked Blocked by research or external factors label Apr 29, 2020
@rauljordan
Copy link
Contributor Author

Resolved in v0.12, running in dev testnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nisdas nisdas

Labels
Blocked Blocked by research or external factors Priority: High High priority item
Projects
None yet
Milestone
Multiclient Readiness
Development

No branches or pull requests
3 participants
@rauljordan @shayzluf @nisdas