Do not send zero hash on FCU #14947
Open
Do not send zero hash on FCU #14947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
force-pushed
the
dont_fcu_to_nil
branch
from
185a98c to
3174f20
Compare
nisdas
previously approved these changes
Feb 18, 2025
saolyn
previously approved these changes
Feb 18, 2025
potuz
force-pushed
the
dont_fcu_to_nil
branch
from
3174f20 to
3555925
Compare
saolyn
approved these changes
Feb 18, 2025
nisdas
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On devnets/kurtosis runs, when the first few blocks are missed,
lateBlockTasksattempts to send an FCU to the zero hash. This panics as the engine retuns and error for an invalid block and we try to invalidate the finalized checkpoint in forkchoice.