Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go to 1.24.0 #14969

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Update go to 1.24.0 #14969

wants to merge 14 commits into from

Conversation

prestonvanloon
Copy link
Member

@prestonvanloon prestonvanloon commented Feb 21, 2025 •
edited
Loading

What type of PR is this?

Other

What does this PR do? Why is it needed?

The primary goal of this PR is to update Prysm to go1.24.0

The following major changes were made:

  • Update staticcheck to v0.6.0
  • Update to go 1.24.0
  • Update github.com/trailofbits/go-mutexasserts to latest
  • Use rules_go @ cf3c3af34bd869b864f5f2b98e2f41c2b220d6c9
  • Provide the go binary to SszGen.
  • Unskip SA9003 static check
  • Fixed issue with SszGen where the go binary was not present in the $PATH.
  • Fixed use of deprecated rand.Seed

Which issues(s) does this PR fix?

Other notes for review

Acknowledgements

@prestonvanloon prestonvanloon force-pushed the go1.24.0 branch 6 times, most recently from e947975 to 7003343 Compare February 21, 2025 18:38
This was referenced Feb 21, 2025
Merged
Merged
@prestonvanloon prestonvanloon force-pushed the go1.24.0 branch 3 times, most recently from e975a4e to 28c7624 Compare February 23, 2025 20:43
@prestonvanloon prestonvanloon mentioned this pull request Feb 23, 2025
Closed
3 tasks
@prestonvanloon prestonvanloon mentioned this pull request Feb 23, 2025
Merged
3 tasks
@prestonvanloon prestonvanloon force-pushed the go1.24.0 branch 4 times, most recently from d9a8444 to 9095af1 Compare February 24, 2025 06:48
@prestonvanloon prestonvanloon marked this pull request as ready for review February 24, 2025 15:30
@prestonvanloon prestonvanloon requested a review from a team as a code owner February 24, 2025 15:30
james-prysm
james-prysm approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@james-prysm james-prysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prestonvanloon prestonvanloon added the Blocked Blocked by research or external factors label Feb 25, 2025
@prestonvanloon
Copy link
Member Author

Let's wait to merge this until after Holesky has stabilized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-prysm james-prysm james-prysm approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@dB2510 dB2510 Awaiting requested review from dB2510 dB2510 is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Blocked Blocked by research or external factors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestonvanloon @james-prysm