Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fork Version Handling in Monitoring and Network Modules #14991

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

kilavvy
Copy link

@kilavvy kilavvy commented Feb 26, 2025

Description:

This pull request introduces several updates to the handling of fork versions across the monitoring and network modules. Key changes include:

  1. Monitoring Module:

    • Added memory_node_bytes_buffered to the monitoring properties to enhance memory tracking.
  2. Network Module:

    • Updated the wantedForkVersion field to ensure it correctly reflects the desired fork version in various test cases.
    • Adjusted the TestNextForkData function to validate the fork version and epoch more effectively.
  3. Key Manager Tests:

    • Renamed the test function for clarity, ensuring it accurately describes its purpose.

These changes aim to improve the accuracy and reliability of fork version management within the system. Please review the modifications and provide feedback.

@kilavvy kilavvy requested a review from a team as a code owner February 26, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant