add log for committee index on electra attesation #14993
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
commented
Feb 26, 2025
| @@ -291,6 +291,8 @@ func (a *AttestationElectra) GetCommitteeIndex() primitives.CommitteeIndex { | |||
| indices := a.CommitteeBits.BitIndices() | |||
| if len(indices) == 0 { | |||
| return 0 | |||
| } else if len(indices) != 1 { | |||
| log.WithField("indices", a.CommitteeBits).Debugf("expected 1 committee bit indice got %d", len(indices)) | |||
There was a problem hiding this comment.
debug or error more appropriate here?
james-prysm
commented
Feb 26, 2025
| import "github.com/sirupsen/logrus" | ||
|
|
||
| var logger = logrus.StandardLogger() | ||
| var log = logger.WithField("prefix", "protobuf") |
There was a problem hiding this comment.
what do you think about this prefix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
electra attestations need to calculate their committee index from the committee bits, this should only be 1 set value, but we should log in the case of this not being true. It would mean this function is called improperly
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements