Upgrade to prisma 5.9.1, feathers 4.5.17 #18
Conversation
* WIP: improve typings * 0.6.3-0 * 🔨 improved Model typings * ✨ new build * 0.6.3-1 * changed typings * new params.prisma property Co-authored-by: Nico Lazarus <[email protected]>
…tests fix: upgrade to prisma 5.9.1, feathers 4.5.17
| "description": "A Feathers service adapter for Prisma ORM.", | ||
| "version": "0.6.0", | ||
| "homepage": "https://github.com/ps73/feathers-prisma", | ||
| "version": "0.12.0", |
There was a problem hiding this comment.
I assume this will be updated to "1.0.0" when the "release:major" npm script is run.
| } | ||
|
|
||
| async _find(params: Params = {}): Promise<any> { | ||
| async _find(params: Params = {}) { |
| } | ||
|
|
||
| return include; | ||
| // we don't care about feathers compliance, we want where queries in our include |
There was a problem hiding this comment.
This seems like a major diversion between the two forks. Not sure if this change should be accepted. Although, it might be a welcome change as I have noticed problems with where clauses in queries our system makes... Some extra scrutiny is needed here.
The comment "we want where queries in our include" is unclear, should this read "we want where queries to be included"?
|
Hi @robblovell, thanks for this PR. Since the fork from triggercodedev includes some changes that I cannot really check if they behave correctly in the feathers context so I took the best parts of it and moves it to a new branch called prisma-v5. |
Prisma 5 Support
This PR incorporates changes made in the fork https://github.com/triggercode/feathers-prisma and some additional upgrades that gets feathers-prisma to prisma 5.9.1 and feathers 4.5,17.
Most of the changes are from triggercode's fork. The major unknowns are around the way the utils.ts file was changed to not care about feathers.js compliance to allow where queries
Open issue addressed: #16
I would recommend going to a major version change with this PR, to version 1.0.0.