Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a page is moved to the trash, its slug should always change, even if it has been edited #385

Closed
boutell opened this issue Nov 19, 2015 · 2 comments
Closed

If a page is moved to the trash, its slug should always change, even if it has been edited #385

boutell opened this issue Nov 19, 2015 · 2 comments
Labels
bug
Milestone
Apostrophe 0.5

Comments

@boutell
Copy link
Member

boutell commented Nov 19, 2015

Normally, Apostrophe leaves user-customized slugs alone when changing the parent of a page. However, the trash can should be an exception to this rule. Otherwise, the trashed page continues to block the reuse of its slug by a new page, which is frustrating.
@jth- jth- added this to the Apostrophe 0.5 milestone Feb 1, 2016
@jth- jth- removed the review label Feb 1, 2016
@jth- jth- mentioned this issue Feb 1, 2016
Closed
@warent
Copy link

warent commented Nov 21, 2016

I've encountered this issue :(

@boutell boutell added 2.0+ and removed 0.5 labels Jan 12, 2017
@boutell boutell mentioned this issue Jan 12, 2017
Closed
boutell pushed a commit that referenced this issue Jan 13, 2017
fix trash slugs, #385; also guarantee uniqueness
e7a4ffa
boutell pushed a commit that referenced this issue Jan 13, 2017
Merge pull request #791 from punkave/fix-trash-slugs
13785cd 
fix trash slugs, #385; also guarantee uniqueness
@boutell
Copy link
Member Author

boutell commented Feb 14, 2017

This has been resolved.

@boutell boutell closed this as completed Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Apostrophe 0.5
Development

No branches or pull requests
3 participants
@boutell @jth- @warent