debian virtual hosts should be created in sites-available with symlink in sites-enabled

[mw44118]

The debian convention is to make a file in /etc/apache2/sites-available for each virtual host, and then use the a2ensite script to enable that virtual host.

The a2ensite script sets up a symbolic link pointing to the file from sites-enabled.

This puppet module instead just drops the file right in sites-enabled.

It works OK, but it isn't conventional.

[dperetti]

Worse than that, pre-existing enabled sites are "purged" by apache::init.pp.

[mw44118]

Oh, yeah, that is kind of gnarly. Glad you called that out! That's a bigger bug than my little peeve.

[HNygard]

+1

[stolsvik]

+1, and +1.

In my opinion, this is quite bad, both not following conventions, and completely ignoring any existing config by simply removing everything in there. That's not clean, not modular, not "separation of concerns", and not "mind your own business".

[jefflaporte]

+1

[bmurtagh]

+1