Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All occurances of <Directory> should double-quote the Directory string. #472

Closed
igalic opened this issue Nov 18, 2013 · 1 comment
Closed

Comments

@igalic
Copy link
Contributor

igalic commented Nov 18, 2013

Relating to #459, upon closer inspection of our source-code I noticed that there is a lot of code that creates <Directory> (Or related) blocks but neglects to double-quote the following string.

This is bad, because that <Directory> could contains spaces. On Windows, this is almost a given.

@Aethylred
Copy link
Contributor

My opinion would be that quotes, and the resulting requirements to escape characters within quotes, should submitted as parameters. ...and would allow the parameter to use ~ to indicate a regex, which needs to be outside the "quotes"

http://httpd.apache.org/docs/current/mod/core.html#directory see regex

(remembering to link the current docs this time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants