Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSCODE] Add a snippet or command to add link and script tags to index pages for manifest and service worker #2628

Closed
nmetulev opened this issue Feb 16, 2022 · 1 comment · Fixed by pwa-builder/pwa-studio#70

Comments

@nmetulev
Copy link
Member

Tell us about your feature idea

Generating a manifest or a service worker also requires updating the head of the index page. The service worker generation attempts to do this automatically but it doesn't always work depending on the framework or setup of the project. The vscode extension should have snippets or commands to insert the link or script tag at the current open file.

Do you have an implementation or a solution in mind?

A simple snippet should work

Have you considered any alternatives?

No

@jgw96
Copy link
Contributor

jgw96 commented Apr 26, 2022

Fixed with above PR

@jgw96 jgw96 closed this as completed Apr 26, 2022
Repository owner moved this from In Progress 🚧 to Done ✔️ in PWABuilder Apr 26, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done ✔️
Development

Successfully merging a pull request may close this issue.

3 participants