Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSCODE] Existing ServiceWorker not taken into account #3180

Closed
1 task done
adrausch opened this issue Jul 11, 2022 · 2 comments
Closed
1 task done

[VSCODE] Existing ServiceWorker not taken into account #3180

adrausch opened this issue Jul 11, 2022 · 2 comments
Assignees

Comments

@adrausch
Copy link

adrausch commented Jul 11, 2022

What happened?

Hello,

When using the "validate PWA" option:
Screenshot 2022-07-11 at 22 48 54
I can add my existing manifest.json file, but the serviceWorker.ts is just grey
Screenshot 2022-07-11 at 22 49 54

When I'm using the sidebar, I can select my "serviceWorker.ts" file but nothing happened.
Screenshot 2022-07-11 at 23 29 28

I tried to create a serviceWorker2.ts with just
import { precacheAndRoute } from 'workbox-precaching/precacheAndRoute'; precacheAndRoute([{"revision":"56c0643d438746f025130b884697fcd1","url":"index.css"}]);
But this file was not accepted by PWA Studio either...

PS: if you need more context, the project I'm working with is the only repo I have on my github account

What do you expect to happen?

I expected that one of my serviceworker file would be taken into account. I really have no suggestion on how to fix the issue

What version of VS Code are you using?

VS Code Stable

Relevant log output

No response

Are you using the latest version of the VS Code extension?

  • I am using the latest version of the VS Code extension
@zateutsch
Copy link
Contributor

At first glance, I would imagine that this is happening because .ts isn't an expected filetype but I'm not sure.

@jgw96 can you confirm this?

If this is the case, should be an easy fix.

@nmetulev nmetulev moved this from Proposed 💡 to In Progress 🚧 in PWABuilder Jul 19, 2022
@jgw96
Copy link
Contributor

jgw96 commented Aug 2, 2022

@zateutsch after looking at it I think its a little bit of a file path issue too, I think Ill have this one done today.

@jgw96 jgw96 moved this from In Progress 🚧 to Done ✔️ in PWABuilder Aug 18, 2022
@jgw96 jgw96 closed this as completed Aug 18, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done ✔️
Development

No branches or pull requests

3 participants