Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix movement of extras to json_schema_extra #15

Merged
merged 6 commits into from
Dec 17, 2023

Conversation

tlambert03
Copy link
Member

there's a bug in the handling of extra kwargs to Fields.

This PR makes it so that **extras are added to json_schema_extra (i.e. with update), instead of the key metadata

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dcb72bb) 94.69% compared to head (0c23625) 94.64%.

Files Patch % Lines
src/pydantic_compat/_v1/mixin.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   94.69%   94.64%   -0.06%     
==========================================
  Files           8        8              
  Lines         264      280      +16     
==========================================
+ Hits          250      265      +15     
- Misses         14       15       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant