-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to pyo3 0.18 #6935
Upgrade to pyo3 0.18 #6935
Conversation
7916e27
to
d65320d
Compare
Could you also rebase this just to see if it fixes coverage? |
@reaperhulk it won't -- the coverage issue is caused by removing the RHEL8-fips builder because it's py36. When we get to this point we'll need to decide what to do about that. |
RHEL 8 comes with Python 3.8 and 3.9.
|
Ah interesting, I guess we should send a PR to infra to install in addition to the base python3 package. |
Not all Python 3.6 modules are available. The AppStream modules for 3.8 and 3.9 provide a limited subset of important packages. cryptography is considered important. 🥇
|
4300bfa
to
363e155
Compare
b86b44b
to
920cafa
Compare
22cbd36
to
28336dd
Compare
2cc58ad
to
67a2f9d
Compare
6686960
to
4a010d8
Compare
a3d97aa
to
2979a2c
Compare
690601d
to
48b4b48
Compare
86e493c
to
730793a
Compare
4e51180
to
315c363
Compare
Follow up action items:
crate::intern!()
to usepyo3::intern!()
for basically all static strings which are converted to PyObjectPy<PyBytes>::as_bytes
instead of copying data to vec.let py = gil.python();
in many places