Migrate from setup.cfg to pyproject.toml completely #8116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
remove-setup-cfg
branch
2 times, most recently
from
0aa1a27 to
addc261
Compare
|
minimum setuptools version this requires is py37 only, so alas, this is on hold |
|
with pyca/infra#449 this will be green (though not mergable until 41) |
alex
force-pushed
the
remove-setup-cfg
branch
2 times, most recently
from
7cbe3ad to
a9b39eb
Compare
reaperhulk
reviewed
Jan 23, 2023
alex
force-pushed
the
remove-setup-cfg
branch
2 times, most recently
from
a4eee73 to
b163d9f
Compare
Viicos
reviewed
Feb 21, 2023
|
|
||
| [tool.setuptools.dynamic] | ||
| version = {attr = "cryptography.__version__"} | ||
| readme = {file = "README.rst", content-type = "text/x-rst"} |
There was a problem hiding this comment.
iirc, readme isn't required to be dynamic if an extension (.rst in this case) is provided. See https://packaging.python.org/en/latest/specifications/declaring-project-metadata/#readme for reference
This comment was marked as spam.
This comment was marked as spam.
One less file?
reaperhulk
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One less file?