Add annotations for ModuleType

[cdce8p]

Description

Replace collections.namedtuple with typing.NamedTuple. An issue here is that ModuleType previously implemented a custom __new__ method which modified one parameter name type vs module_type. This PR modifies the constructor parameter name (module_type). That way all existing ModuleSpec instances can still access the type attribute.

I've added a changelog entry since technically it's a breaking change. However, I don't think anyone should be impacted by it. ModuleType is (almost ?) exclusively used for internal code.

[coveralls]

Pull Request Test Coverage Report for Build 2210064454

• 20 of 20 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.009%) to 91.575%

---

Totals
Change from base Build 2209158259:	0.009%
Covered Lines:	9119
Relevant Lines:	9958

---

💛 - Coveralls

[Pierre-Sassoulas]

LGTM, nice cleanup, and also performance improvement because named tuple using exec are slow. I think we were using module_type instead of type because type is a builtin and pylint is raising a warning for this.

[Pierre-Sassoulas]

There was a useless implicit string concatenation here.

[cdce8p]

Yeah, could have been to indicate the optional parameter originally, but I'm not certain.

[cdce8p]

I think we were using module_type instead of type because type is a builtin and pylint is raising a warning for this.

Probably. Unfortunately, that's always a risk when dealing with the name type. In this case it should be fine though. We are already using it for attribute access anyway and the new constructor arguments aren't causing any issues either.