Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOML dependency declaration is outdated #5066

Closed
jeroenseegers opened this issue Sep 23, 2021 · 0 comments · Fixed by #5067
Closed

TOML dependency declaration is outdated #5066

jeroenseegers opened this issue Sep 23, 2021 · 0 comments · Fixed by #5067
Labels
Bug 🪲 Crash 💥 A bug that makes pylint crash
Milestone

Comments

@jeroenseegers
Copy link
Contributor

jeroenseegers commented Sep 23, 2021

Bug description

The toml dependency is declared as >=0.7.1, however, since this #4176 has been merged the dependency should state >=0.10.

I came across this due to a shared dependency on toml between two packages, of which one has toml<0.10,>=0.9 causing toml==0.9.6 to be installed.

Configuration

No response

Command used

pylint --version

Pylint output

Traceback (most recent call last):
  File "/usr/local/bin/pylint", line 8, in <module>
    sys.exit(run_pylint())
  File "/usr/local/lib/python3.8/site-packages/pylint/__init__.py", line 21, in run_pylint
    from pylint.lint import Run as PylintRun
  File "/usr/local/lib/python3.8/site-packages/pylint/lint/__init__.py", line 76, in <module>
    from pylint.lint.parallel import check_parallel
  File "/usr/local/lib/python3.8/site-packages/pylint/lint/parallel.py", line 9, in <module>
    from pylint.lint.utils import _patch_sys_path
  File "/usr/local/lib/python3.8/site-packages/pylint/lint/utils.py", line 10, in <module>
    from pylint.config import PYLINT_HOME
  File "/usr/local/lib/python3.8/site-packages/pylint/config/__init__.py", line 46, in <module>
    from pylint.config.find_default_config_files import find_default_config_files
  File "/usr/local/lib/python3.8/site-packages/pylint/config/find_default_config_files.py", line 8, in <module>
    from toml.decoder import TomlDecodeError
ModuleNotFoundError: No module named 'toml.decoder'; 'toml' is not a package

Expected behavior

I would expect version numbers to be printed.

Pylint version

pylint 2.11.1

OS / Environment

Debian 10 Buster

Additional dependencies

pylint==2.11.1
toml==0.9.6

@jeroenseegers jeroenseegers added Bug 🪲 Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling labels Sep 23, 2021
@Pierre-Sassoulas Pierre-Sassoulas added Crash 💥 A bug that makes pylint crash and removed Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling labels Sep 23, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.11.2 milestone Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🪲 Crash 💥 A bug that makes pylint crash
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants