Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable bad-docstring-quotes for Python 3.7 #6087

Closed
DanielNoord opened this issue Apr 1, 2022 · 1 comment · Fixed by #6148
Closed

Re-enable bad-docstring-quotes for Python 3.7 #6087

DanielNoord opened this issue Apr 1, 2022 · 1 comment · Fixed by #6148
Labels
Enhancement ✨ Improvement to a component Good first issue Friendly and approachable by new contributors
Milestone
2.14.0

Comments

@DanielNoord
Copy link
Collaborator

Current problem

With changes to doc_node in astroid we can now check docstring quotes in 3.7 as well. This was turned off in #5526.

Desired solution

Turn the checker on again.

Additional context

@kasium Do you still want to do this? Should I assign you?
@DanielNoord DanielNoord added Enhancement ✨ Improvement to a component Good first issue Friendly and approachable by new contributors labels Apr 1, 2022
@DanielNoord DanielNoord added this to the 2.14.0 milestone Apr 1, 2022
@jpy-git jpy-git mentioned this issue Apr 2, 2022
Merged
@gunungpw gunungpw mentioned this issue Apr 3, 2022
Closed
1 task
@kasium
Copy link
Contributor

kasium commented Apr 7, 2022

@DanielNoord thanks for checking. Seems I was too slow 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement ✨ Improvement to a component Good first issue Friendly and approachable by new contributors
Projects
None yet
Milestone
2.14.0
Development

Successfully merging a pull request may close this issue.

Re-enable checker bad-docstring-quotes for Python <= 3.7. jpy-git/pylint
2 participants
@DanielNoord @kasium