Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad-plugin-value error in version 2.14.2 and 2.14.3 #7005

Closed
danawillow opened this issue Jun 22, 2022 · 2 comments
Closed

bad-plugin-value error in version 2.14.2 and 2.14.3 #7005

danawillow opened this issue Jun 22, 2022 · 2 comments
Labels
Duplicate 🐫 Duplicate of an already existing issue

Comments

@danawillow
Copy link

Bug description

When upgrading from 2.14.1 to 2.14.2 or 2.14.3, our pylint stops working with this error: Command line or configuration file:1:0: E0013: Plugin 'recidiviz.tools.lint.pylint_checkers' is impossible to load, is it installed ? ('No module named 'recidiviz'') (bad-plugin-value)

Reproduction steps:

  1. git clone https://github.com/Recidiviz/pulse-data.git
  2. cd pulse-data
  3. pipenv shell
  4. pipenv sync --dev
  5. pip install pylint==2.14.2
  6. pylint recidiviz/server_config.py

(there is other pylint output there because this repo is a 2 week old copy of the private repository we're actually doing work in. I can repro the issue in both, but don't get the additional output in the up-to-date one)

Configuration

I'm not sure what's causing the bug, so here's a few relevant configs:
https://github.com/Recidiviz/pulse-data/blob/main/.pylintrc
https://github.com/Recidiviz/pulse-data/blob/main/setup.cfg
https://github.com/Recidiviz/pulse-data/blob/main/recidiviz/tools/lint/pylint_checkers.py

Command used

pylint recidiviz/server_config.py (but that specific file isn't important- it fails on all of them)

Pylint output

************* Module Command line or configuration file
Command line or configuration file:1:0: E0013: Plugin 'recidiviz.tools.lint.pylint_checkers' is impossible to load, is it installed ? ('No module named 'recidiviz'') (bad-plugin-value)

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

Expected behavior

Expect no error

Pylint version

pylint 2.14.2
astroid 2.11.6
Python 3.9.11 (main, Apr 29 2022, 09:32:35)
[Clang 13.1.6 (clang-1316.0.21.2)]

OS / Environment

mac OS 12.3.1

Additional dependencies

(I don't think you'll need this to repro the issue but let me know)

@danawillow danawillow added the Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling label Jun 22, 2022
@jacobtylerwalls
Copy link
Member

Hi @danawillow, thanks for the report.

I see an init-hook with quoted code in your config, which suggests to me this is the same issue as #7006. Would you be willing to try unquoting the code and see if that A.) provides a short-term workaround, and B.) confirms this to be the same root cause?

@jacobtylerwalls jacobtylerwalls added Waiting on author Indicate that maintainers are waiting for a message of the author and removed Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling labels Jun 23, 2022
@danawillow
Copy link
Author

Unquoting worked! Sounds like this is the same root cause, so I'll go ahead and close this issue. Thanks for the speedy diagnosis and workaround!

@jacobtylerwalls jacobtylerwalls added Duplicate 🐫 Duplicate of an already existing issue and removed Waiting on author Indicate that maintainers are waiting for a message of the author labels Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate 🐫 Duplicate of an already existing issue
Projects
None yet
Development

No branches or pull requests

2 participants