Fix #3675: safe_infer() finds ambiguity among function definitions when number of arguments differ
#5409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1541232939
💛 - Coveralls |
jacobtylerwalls
changed the title
safe_infer now finds ambiguity when number of arguments differsafe_infer now finds ambiguity among function definitions when number of arguments differ
jacobtylerwalls
changed the title
safe_infer now finds ambiguity among function definitions when number of arguments differsafe_infer() finds ambiguity among function definitions when number of arguments differ
DanielNoord
reviewed
Dec 4, 2021
…arguments differ
TemporaryFile may or may not be NamedTemporaryFile depending on system platform, and astroid has no way of knowing this, so abort.
jacobtylerwalls
force-pushed
the
ticket_3675
branch
from
ccb87e0 to
13ebc62
Compare
DanielNoord
requested changes
Dec 4, 2021
Co-authored-by: Daniël van Noord <[email protected]>
DanielNoord
reviewed
Dec 4, 2021
DanielNoord
added
the
Needs astroid update
2 tasks
DanielNoord
added
False Positive 🦟
DanielNoord
approved these changes
Dec 5, 2021
There was a problem hiding this comment.
With that discussion solved, this is now good to go!
Thanks @jacobtylerwalls, also for pointing to the code that relied on args being None!
Pierre-Sassoulas
approved these changes
Dec 5, 2021
|
@Pierre-Sassoulas I think this can be merged? Or are we waiting on something? |
|
I probably thought Marc would want to review, but we can merge, most MR do not have 3 approbations. |
cdce8p
added a commit
to cdce8p/pylint
that referenced
this pull request
Feb 6, 2022
* Add additional isinstance check * Originally added in pylint-dev#5409
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Feb 6, 2022
* Add additional isinstance check * Originally added in #5409
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Before
safe_infermight confuse two function definitions having different numbers of arguments.Now
It won't.
But there is an inference problem withUpdate: the wayTemporaryFilebeing inferred asNamedTemporaryFile, which has an extra argument (delete), so I special-cased it. Is that an Astroid issue?tempfiledefines the nameTemporaryFileconditionally based on platform means Astroid finds ambiguity.Closes #3675