Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude dunder calls on super() from raising unnecessary-dunder-call #6113

Merged
merged 4 commits into from
Apr 2, 2022
Merged

Exclude dunder calls on super() from raising unnecessary-dunder-call #6113

merged 4 commits into from
Apr 2, 2022

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Apr 1, 2022

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #6074. Allows dunder method calls on super()

jacobtylerwalls
jacobtylerwalls reviewed Apr 1, 2022
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@coveralls
Copy link

coveralls commented Apr 2, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2080364233

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.272%
Totals Coverage Status
Change from base Build 2079916425: 0.0%
Covered Lines: 15503
Relevant Lines: 16445
💛 - Coveralls

@jacobtylerwalls jacobtylerwalls added this to the 2.14.0 milestone Apr 2, 2022
@Pierre-Sassoulas Pierre-Sassoulas merged commit 551981b into pylint-dev:main Apr 2, 2022
@Pierre-Sassoulas Pierre-Sassoulas added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Apr 2, 2022
@jpy-git jpy-git deleted the super_dunder_call branch April 2, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@jacobtylerwalls jacobtylerwalls jacobtylerwalls approved these changes

Assignees
No one assigned
Labels
False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

False positive unnecessary-dunder-call when overriding dunder method
4 participants
@jpy-git @coveralls @Pierre-Sassoulas @jacobtylerwalls