Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write the exception message to stderr in ASTWalker.walk #6598

Merged
merged 4 commits into from
May 12, 2022

Conversation

yilei
Copy link
Contributor

@yilei yilei commented May 12, 2022

Type of Changes

Type
βœ“ πŸ› Bug fix
✨ New feature
πŸ”¨ Refactoring
πŸ“œ Docs

Description

Write the exception message to stderr, otherwise stdout would produce invalid formatted outputs (e.g. --output-format=json).

Closes #6597

yilei and others added 2 commits May 12, 2022 14:40
Otherwise stdout would produce invalid formatted outputs (e.g. `--output-format=json`).
@coveralls
Copy link

coveralls commented May 12, 2022

Pull Request Test Coverage Report for Build 2316572697

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0003%) to 95.345%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pylint/utils/ast_walker.py 1 2 50.0%
Totals Coverage Status
Change from base Build 2315870463: 0.0003%
Covered Lines: 16036
Relevant Lines: 16819

πŸ’› - Coveralls

@jacobtylerwalls jacobtylerwalls modified the milestones: 2.13.9, 2.14.0 May 12, 2022
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@jacobtylerwalls jacobtylerwalls changed the title Write the exception message to stderr. Write the exception message to stderr in ASTWalker.walk May 12, 2022
@jacobtylerwalls jacobtylerwalls merged commit 2ea65b1 into pylint-dev:main May 12, 2022
@yilei yilei deleted the stdout branch May 13, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plain text outputs to stdout invalidate the non-text outputs formatting
3 participants