Prevent pylint.run._cpu_count() from returning 0

[d1gl3]

Type of Changes

	Type
✓	🐛 Bug fix

Description

If --jobs=0 is passed to pylint, sometimes pylint.run._query_cpu will return 0. This later leads to a crash when passed to multiprocessing.pool.Pool as this requires more an integer >= 1 for processes.
Therefore, we just check the return value of pylint.run._query_cpu to evaluate to True instead of not None.

Closes #6902

[coveralls]

Pull Request Test Coverage Report for Build 2481042270

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.006%) to 95.529%

---

Totals
Change from base Build 2480664845:	0.006%
Covered Lines:	16387
Relevant Lines:	17154

---

💛 - Coveralls

[Pierre-Sassoulas]

👍

[DanielNoord]

Suggested change

	if avail_cpu == 0:
	avail_cpu = 1
	return avail_cpu
	return max(avail_cpu, 1)

A little bit more explicit imo. I didn't know 0,1 == 0 so people might forget that as well later on.

[d1gl3]

0,1 == 0 can't happen here, as it's getting rounded to the next int so avail_cpu is either 0 or >=1 there. Nevertheless, what I also thought of was, if just shortcircuiting the return wouldn't be the more elegant solution:

Suggested change

	if avail_cpu == 0:
	avail_cpu = 1
	return avail_cpu
	return avail_cpu or 1

But yours is more explicit though.

[d1gl3]

I did apply your suggestion, but this is failing due to avail_cpu being initialized as None (a valid return value for this function imo) which does not work with max. My proposal above also doesn't work here. If the function doesn't find any of the files used to determine cpus, it is just wrong to return 1 cpu available then.

Therefore I just reverse that change to my initial implementaion, only in case of avail_cpu == 0 this should be set automatically to 1

[Pierre-Sassoulas]

Thank you for the great fix @d1gl3 ! It will be available in the next patch version.

[github-actions]

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 0854005