Fix false positive for no-self-argument
#7301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ied to a function but uses a different name. Closes pylint-dev#7300
Pull Request Test Coverage Report for Build 2852893062
💛 - Coveralls |
This comment has been minimized.
This comment has been minimized.
jacobtylerwalls
previously approved these changes
Aug 13, 2022
jacobtylerwalls
added
the
False Positive 🦟
| @@ -1,8 +1,15 @@ | |||
| """Check for method without self as first argument""" | |||
| # pylint: disable=useless-object-inheritance | |||
| from __future__ import print_function | |||
There was a problem hiding this comment.
Nice catch ! If there are a lot of those we could create another merge request to fix all of those python2 remnants at once
Co-authored-by: Jacob Walls <[email protected]>
Co-authored-by: Jacob Walls <[email protected]>
Co-authored-by: Jacob Walls <[email protected]>
jacobtylerwalls
approved these changes
Aug 13, 2022
Pierre-Sassoulas
approved these changes
Aug 13, 2022
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit dc58f0c |
|
Thank you for fixing the issue @mbyrnepr2!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix false positive for
no-self-argumentwhen a staticmethod is applied to a function but uses a different name.Closes #7300