Sort --generate-rcfile ouput
#7655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdce8p
added
Enhancement ✨
Pull Request Test Coverage Report for Build 3297070891
💛 - Coveralls |
This comment has been minimized.
This comment has been minimized.
| for group in sorted( | ||
| self._arg_parser._action_groups, | ||
| key=lambda x: (x.title != "Main", x.title), | ||
| ): |
There was a problem hiding this comment.
Shouldn't the options also be sorted line 460 to 464 ?
There was a problem hiding this comment.
👍🏻 Done, although it didn't change much. I force pushed the changes to keep the history clean for the merge commit.
cdce8p
force-pushed
the
sort-gen-rcfile
branch
from
1835d36 to
9cc5674
Compare
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 9cc5674 |
cdce8p
added
Backported
and removed
Needs backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sort output of
--generate-rcfilesimilar to the one from--generate-toml-configand update example pylintrc.Noticed this while trying the release workflow.
Note: To make backporting easier, don't squash merge this PR.
https://github.com/PyCQA/pylint/blob/15dd079792ce8e6b37856450f9e4a928f11b3549/pylint/config/arguments_manager.py#L704-L707