-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip-10.0.0 misinterprets version restrictions in pyproject.toml #5298
Comments
Correct - this is a limitation of the current PEP 518 support in pip. See the docs for details. Pandas appears to have already started using PEP 518 features in its sources - which is questionable, as no existing installer provides full support for PEP 518 yet. But you'd have to take it up with them as to why they chose to do that. |
Also, note that PEP 518 build dependencies will always be installed from wheels. @pfmoore: maybe we should add a warning to the current implementation if the user asked for sources only and pip needs to handle a PEP 518 project. |
That may be a good idea - it depends on whether source support makes it into 10.1 TBH. Not much point in putting a warning in 10.1 if we're fixing the issue in that release :-) |
Looking good I'd say. Seems like pandas has already realized there is an issue and removed the file from their master: |
It's removed in the meantime (but we can't change the released versions that already have it of course). Another suggestion would be: disable PEP 518 support by default in pip until it is better supported. That would also fix all the installation problems with the latest pip we are seeing. |
I'd rather that we improve support as we can, in pip, in the near future and make a release. |
Yes, but the discussion on other issues gave me the impression that that would take some time (eg supporting not only wheels in build dependencies). And if that is a case, a pip with the support disabled by default would give less user problems until then. |
They'll be supported in the next release of pip, which should be ~start of July. |
For those of you running into this issue and cannot find the work around until next pip/pandas release in a docker file for Alpine3.6/7 add the line: |
This can probably be closed as another duplicate of #5229. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description:
Building a wheel for pandas results in:
What I've run:
Commenting in the install "pip<10" fixes the issue. So this is a regression from pip-10.0.0.
Looking at the pandas repository, the numpy==1.9.3 is coming from https://github.com/pandas-dev/pandas/blob/v0.22.0/pyproject.toml
There is a version restriction to python-3.5 though, which pip seems to ignore.
The text was updated successfully, but these errors were encountered: