Reduce dependence on disk files during Wheel installation #8526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
added
the
skip news
chrahunt
force-pushed
the
reduce-dependence-on-files
branch
from
b0a3cf7 to
60ffe20
Compare
uranusjr
reviewed
Jul 3, 2020
`source` is provided as an argument to this function. Shadowing it can lead to type errors if the intermediate types change.
This reduces our dependence on the files being extracted to the filesystem. Compare the name extraction to the similar code in `utils.wheel.wheel_dist_info_dir`. We don't need to give `.data` directories the same strict treatment (yet) because it isn't inconvenient if there happen to be multiple of them in a single Wheel file.
Reducing the scope of variables reduces possible dependencies between parts of this function, and will make it easier to extract this section into its own function.
chrahunt
force-pushed
the
reduce-dependence-on-files
branch
from
60ffe20 to
abed1d6
Compare
pradyunsg
approved these changes
Jul 3, 2020
uranusjr
approved these changes
Jul 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of several places where we're depending on files on disk during Wheel installation. Removing it brings us closer to installing directly from Wheel files.
Progresses #6030.