Update WorkingSet.find to consider standardised .dist-info directory names.
#4856
+71
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think changing the |
2 tasks
|
I will have a look shortly on the windows path normalisation thing going on with the failing test. |
|
@abravalheri Looks like this is a better solution, there is a test failing in #4855 that is related to namespace packages that this seems to avoid. |
|
Thanks @di, let's go with this one then and get it out soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Alternative to #4855
Closes #4853.
/cc @di: We wore working kind of in parallel on this. What are your thoughts? I don't have any strong preference regarding the 2 proposed approaches (either #4855 or #4856 are fine to me).
Pull Request Checklist
newsfragments/.(See documentation for details)