Skip to content

Commit

Permalink
Update 3016.bugfix
Browse files Browse the repository at this point in the history
  • Loading branch information
@nicoddemus
nicoddemus authored Dec 14, 2017
1 parent 35aa325 commit fc6dc4d
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions changelog/3016.bugfix
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
fixed restoring Python state after in-process pytest runs; may break tests using
pytester functionality making multiple inprocess pytest runs if later ones
depend on earlier ones leaking global interpreter changes
Fixed restoring Python state after in-process pytest runs with the ``pytester`` plugin; this may break tests using
making multiple inprocess pytest runs if later ones depend on earlier ones leaking global interpreter changes.

4 comments on commit fc6dc4d

@jurko-gospodnetic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicoddemus - Just wondering, what's the criteria for formatting these changelog files?

Ok, I got you want full sentences even when there's only one. What's the desired line wrap length? I originally formatted it at 80 I think (I typically use that so I can easily display two files side by side and see them whole when comparing in something like Beyond Compare).

@RonnyPfannschmidt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jurko-gospodnetic we use towncrier to merge all those fragments into one changelog, and we need to roughly ensure its nice

@jurko-gospodnetic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I don't think the line length matters as I think towncrier wraps it all together itself. You did not mention any specific line length. Do you have one you target?

As for whether a single sentence entry should be formatted as a full sentence or not - I personally prefer the latter, but will format it as you did from now on in pytest.

@nicoddemus
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I got you want full sentences even when there's only one.

The problem with multiple sentences is just that towncrier doesn't seem to support them correctly, it produces invalid RST. Personally I wouldn't mind multiple entries at all.

What's the desired line wrap length? I originally formatted it at 80 I think

I don't think the line length matters, as soon as it is a single paragraph. I might have changed the line length inadvertently while adding the formatting, sorry about that.

Please sign in to comment.