fixture called by fixtures keep the first context

[ggens]

Hi,
In the same test after a first call, fixture save context and not executed a second time.

let's me show you issue by this exemple as below:

import pytest

@pytest.fixture(name="deep_fixture")
def fixture(request):
    fixture_parent = request._parent_request.fixturename
    if fixture_parent == "fixture_1":
        return "deep_fixture_1"
    if fixture_parent == "fixture_2":
        return "deep_fixture_2"

@pytest.fixture(name="fixture_1")
def fixture_parent_1(request, deep_fixture):
    assert deep_fixture == "deep_fixture_1"

@pytest.fixture(name="fixture_2")
def fixture_parent_2(request, deep_fixture):
    assert deep_fixture == "deep_fixture_2"

def test_fixure_in_fixture(fixture_1 ,fixture_2):
    pass

I'd the result:

    @pytest.fixture(name="fixture_2")
    def fixture_parent_2(request, deep_fixture):
>       assert deep_fixture == "deep_fixture_2"
E       AssertionError: assert 'deep_fixture_1' == 'deep_fixture_2'
E         - deep_fixture_1
E         ?              ^
E         + deep_fixture_2
E         ?    

[pytestbot]

GitMate.io thinks possibly related issues are #833 (--fixtures only shows fixtures from first file), #3661 (deprecate calling fixtures as functions), #2981 (Session fixture keeps frames of other fixtures alive), #1953 (Extending a fixture does not keep its params), and #2934 (capsysbinary fixture).

[ggens]

yes, it looks like #2981 but with function scope

[RonnyPfannschmidt]

This is just completely invalid as a issue

[ggens]

@RonnyPfannschmidt i would like understand why ? Can me explain the reason please ?

[RonnyPfannschmidt]

@ggens you used a private api that you shouldn't have accessed to begin with and you ignored that fixtures are cached per scope and are not made per usage site