Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate support for old setuptools, plan for drop in 4.0 #3762

Closed
RonnyPfannschmidt opened this issue Aug 1, 2018 · 9 comments
Closed
Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: deprecation feature that will be removed in the future type: enhancement new feature or API change, should be merged into features branch type: feature-branch new feature or API change, should be merged into features branch type: removal marks the actual removal of a feature, usually done in major releases
Milestone

Comments

@RonnyPfannschmidt
Copy link
Member

modern setuptools with environment markers within requirements is released since quite a while now (setuptools 30 series, we are now at setuptools 40)

we should plan to remove the hacks in setup.py and move most of it to setup.cfg

@RonnyPfannschmidt RonnyPfannschmidt added type: enhancement new feature or API change, should be merged into features branch type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: feature-branch new feature or API change, should be merged into features branch type: deprecation feature that will be removed in the future type: removal marks the actual removal of a feature, usually done in major releases labels Aug 1, 2018
@asottile
Copy link
Member

asottile commented Aug 1, 2018

For the most part, as long as pytest provides wheels this probably won't impact many (if any) as the wheel marker support works all the way back to the pip 6.x era

@nicoddemus
Copy link
Member

I guess we could apply the deprecation right away, correct?

@nicoddemus
Copy link
Member

By "right away" I mean in features for pytest 3.8.

@RonnyPfannschmidt
Copy link
Member Author

@nicoddemus i just wanted to track this as a issue first, and see some impact and then sort it out after the regressions are fixed

if nobody complains until the regressions are gone i consider it fair game

@nicoddemus
Copy link
Member

see some impact and then sort it out after the regressions are fixed

Which regressions? The ones that might come up when we deprecate the setuptools support, or the current regressions of the pytest 3.7.0 release?

@RonnyPfannschmidt
Copy link
Member Author

@nicoddemus current ones

@Zac-HD Zac-HD changed the title deprecate support for old setuptools, plan for drop in 3.9 or 4.0 whatever comes first deprecate support for old setuptools, plan for drop in 4.0 Oct 19, 2018
@Zac-HD Zac-HD added this to the 4.0 milestone Oct 19, 2018
@nicoddemus
Copy link
Member

@RonnyPfannschmidt hmmm missed this one.

@nicoddemus nicoddemus modified the milestones: 4.0, 4.1 Nov 22, 2018
@RonnyPfannschmidt
Copy link
Member Author

actually we did it in #4149

@nicoddemus
Copy link
Member

Oh right 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: deprecation feature that will be removed in the future type: enhancement new feature or API change, should be merged into features branch type: feature-branch new feature or API change, should be merged into features branch type: removal marks the actual removal of a feature, usually done in major releases
Projects
None yet
Development

No branches or pull requests

4 participants