Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review/enhance behavioural consistency of the id generation process #4742

Open
RonnyPfannschmidt opened this issue Feb 8, 2019 · 4 comments
Labels
type: refactoring internal improvements to the code

Comments

@RonnyPfannschmidt
Copy link
Member

in #4740 we noted that there was a slight behavioral inconsistency in how we generate ids and how values are passed around in between real ids, the idfn, the id generation hook,

we kept the original behavior, but we really need a corrected outline on the behavior

im proposing this for pytest 6.0 as the correction may have the unwanted consequence of changing some test ids due to now passing trough the hook always

another outcome may be to iron out the cases where the call order should be as it is, and specifying it + tightening that contract with unit-tests

@RonnyPfannschmidt RonnyPfannschmidt added this to the 6.0 milestone Feb 8, 2019
@Zac-HD Zac-HD added the type: refactoring internal improvements to the code label Feb 8, 2019
@nicoddemus
Copy link
Member

@RonnyPfannschmidt you still want to tackle this for 6.0?

@RonnyPfannschmidt RonnyPfannschmidt modified the milestones: 6.0, 6.1 Jun 16, 2020
@nicoddemus
Copy link
Member

@RonnyPfannschmidt gentle ping. Do you think you will be able to tackle this soon?

@RonnyPfannschmidt
Copy link
Member Author

Unfortunately not within the next month

@nicoddemus nicoddemus removed this from the 6.1 milestone Aug 21, 2020
@nicoddemus
Copy link
Member

OK no problem, thanks. I've removed it from the 6.1 milestone then, I don't think it is urgent for that release. Feel free to reschedule it to another version if you would like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactoring internal improvements to the code
Projects
None yet
Development

No branches or pull requests

3 participants