implement #3130 - add record_xml_attribute fixture #3132
Merged
+109
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelcastaneda
force-pushed
the
feature/add-record-xml-attribute
branch
3 times, most recently
from
8d6fe39 to
2fc4175
Compare
raphaelcastaneda
changed the title
raphaelcastaneda
force-pushed
the
feature/add-record-xml-attribute
branch
from
2fc4175 to
a699ec1
Compare
nicoddemus
requested changes
Jan 20, 2018
There was a problem hiding this comment.
The code looks great! Could you please also add some documentation to usage.rst, similar to the description of record_xml_property? I think you can also show the xsd structure you described in #3130 so it is clear what attributes the user is allowed to change.
nicoddemus
approved these changes
Jan 22, 2018
raphaelcastaneda
force-pushed
the
feature/add-record-xml-attribute
branch
from
0d3edc0 to
f518e95
Compare
update incorrect expected attribute value in test_record_attribute attr names must be strings Update CHANGELOG formatting update usage documentation Fix versionadded for record_xml_attribute Indent the xml schema properly inside the warning box in the docs
raphaelcastaneda
force-pushed
the
feature/add-record-xml-attribute
branch
from
f518e95 to
a5e60b6
Compare
|
Squashing the commits. Hopefully this also gives the tests a chance to run without that network error :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows insertion of new xml attributes on
<testcase>elements, or overwriting their default values.